On Tue, Feb 26, 2008 at 09:56:22AM +0100, Stefan Schimanski wrote:
>
> Am 26.02.2008 um 03:03 schrieb Enrico Forestieri:
>
> > On Mon, Feb 25, 2008 at 03:43:51PM +0100, Abdelrazak Younes wrote:
> >
> >> Stefan Schimanski wrote:
> >>>>
> >>>> No, Windoze...
> >>>
> >>> Visual C or gcc?
> >>
> >> Visual C++ 9.0 (aka 2008 express edition). Only Enrico uses gcc for
> >> cygwin purpose I think.
> >
> > For test purpose, I also build a native version with the mingw gcc.
> > BTW, I also get the "lalala l<BOOM>" crash in text mode, and I would
>
> Good to know. So the crash happens on Windows with vc and gcc?! I
> hesitate to install Visual Studio in my Vmware Windows. Haven't heard
> of anybody with a crash on linux though. How big is an installed VC9?
The attached patch avoids the crash for me. Seemingly, it was due
to the docstring const reference, but I don't understand why.
Abdel, does it also cure the crash for you?
--
Enrico
Index: src/frontends/qt4/GuiCompleter.cpp
===================================================================
--- src/frontends/qt4/GuiCompleter.cpp (revision 23288)
+++ src/frontends/qt4/GuiCompleter.cpp (working copy)
@@ -130,9 +130,10 @@ public:
if (role != Qt::DisplayRole && role != Qt::EditRole)
return QVariant();
- if (index.column() == 0)
- return toqstr(list_->data(index.row()));
- else if (index.column() == 1) {
+ if (index.column() == 0) {
+ docstring const word = list_->data(index.row());
+ return toqstr(word);
+ } else if (index.column() == 1) {
// get icon from cache
QPixmap scaled;
QString const name = ":" +
toqstr(list_->icon(index.row()));
