Vincent van Ravesteijn - TNW wrote:
As a general comment on the patch, I didn't review it in detail but
I feel that this is a lot of additional code.
The only new code is in the logic whether to draw the margins or not.
And this was just the problem that I had with how LyX drawn the margins.
Sometimes it does, sometimes with a delay until the next full repaint,
sometimes not at all.
I don't like the new arguments to 'computeRowSignature()'; maybe the
reason is that the Row object doesn't keep track of the boundary; if
you add this member in addition to sel_beg and sel_end I guess you
have everything needed and this will result in lesser code. But that's
just a guess.
I understand. Maybe I oversaw the most obvious solution: Move the
end_margin and beg_margin code before the checksum computation.
Yes, that sounds a better and cleaner solution. We basically only keep
rows that are shown on screen in memory so adding two move variable is
not a big problem.
Now,
basically both computeRowSignature and drawParagraph are doing the same
thing. Then, I maybe only have to pass "row, bparams, bool beg_margin,
and bool end_margin". Can you live with this ? Or indeed, add beg_margin
and end_margin to Row, (I intentionally don't want to use the term
boundary).
The later yes.
I would understand if you feel demotivated by my repetitive comments.
I do not want you to commit code you don't like.
Thanks. I am happy that someone else besides me put some interests into
painting.
PS. Can you still copy-paste insets ? I can't since revision, well
approximately 26360.
No, you're right!
Abdel.
