Tommaso Cucinotta wrote:
Hi,
thanks for keeping me up-to-date. The 1-b) requirement seems
compatible with the one in 4), but of course the "wrap-around"
feature may loss of any meaning.
No, I meant to have this feature in _addition_ to the the conventional
find dialog. Or maybe this feature would be triggered with a 'Find All'
push button. Then the Navigator will display the list of found items.
Actually, are you sure you want an Acrobat-like functionality ?
In _addition_, yes, that would be nice to have, but let us concentrate
on FindAndReplace first.
The major drawback of the current approach, in my view, is the
speed, not rather usability (which instead I find very comfortable
because you can easily do all of the work using the keyboard and
you don't need to switch to the mouse -- with the Acrobat-like thing
I'm scared it becomes mouse-oriented). Also, I was thinking to
go on and implement the "scope" part (selection, document, open
documents, master document).
Of course, if you really decided to go for a binary search, then
everything
is about to change, so I'll refrain myself from further changes.
Also, are you sure we cannot easily speed-up things even keeping the
current text-based search ?
Let me know if and how else I can help.
As I said in my reply to Pavel, general cleanup and API reduction of
lyxfind.h is higly desired. If you could concentrate on that, that would
be great.
Abdel.
T.
Abdelrazak Younes ha scritto:
Hi Tommaso,
I'll try to have a look at your patch later but I'd like first to
outline the decided road-map for this feature:
1) Fix all issues in FindAndReplace dialog, which is based on your
AdvSearch patch. Which also means 1-a) add the Replace function
1-b) switch to a binary search and speed it up.
1-c) cleanup all remaining coding style issues.
2) current GuiSearch dialog will be replaced by new FindAndReplace
dialog
3) add a find-as-you-type feature in the status bar a là Firefox.
4) add a clickable find list in the Navigator similar to what is
available in Acrobat reader.
Abdel.
Tommaso Cucinotta wrote:
Hello,
this implements the wrap option (first pending issue from the wiki):
� Bug 1262 <http://bugzilla.lyx.org/show_bug.cgi?id=1262> Search &
Replace: "wrap" option
only for the entire document scope case, for now. Instead of having
yet another option on the dialog, I'm proposing a simple question
that is popped-up when reaching the wrap-point (default answer
of yes, i.e., continue searching on wrap, is achieved by pressing
Enter on the dialog that is shown, whilst further search is cancelled
through Esc or pressing No).
Just tried with simple text, didn't try with complex insets, maths,
tables
or whatever at begin or end of document. Hopefully, core developers
know much better than me how to place a DocIterator at begin or
at end of the document.
� � T.
