have you checked its not dataloss from multiple windows view as i have warned 
before?
if you have two windows, which have opened the same file and then try to hide 
buffer in one of
the windows, you will ask for save. this imho shouldn't happen, secondly if hit don't save i get reload and lose my changes of this document in the second window?
Yes, you shouldn't get the askForSave thingie,.. (but there's much more wrong with this kind of thing. It was also changed a lot in r27525 with the very interesting comment that it's the second patch from Tomasso, .. Abdel #(*#*($ ?
i haven't followed the whole thread but this feel wrong to me.
Could you be more specific.
it looks like crippling hide feature
Could you be more specific.
and introducing new bugs
Could you be more specific.
(i just got crash when trying the scenario outlined above)
Could you be more specific.

I know about a crash when closing a tab group. This crash was made possible in r27525 and revealed by your saveSelection patch.
instead of fixing the real issue - triggering the dialog when the buffer get 
closed.
The buffers didn't get closed, which is the real issue ;-)

We agreed on the list that we better wanted to make sure that hidden buffers were not dirty. If you didn't like that you had enough opportunities to step up.

Last, I think it's good to clean up the mess. We had no control over dirty buffers and stuff like that, there was duplicated code, and there are at least 3 or more crashes in trac related to this.
pavel
Vincent

Reply via email to