On 08/11/2009 11:54, Abdelrazak Younes wrote:
On 07/11/2009 00:35, Enrico Forestieri wrote:
On Fri, Nov 06, 2009 at 04:50:17PM +0100, Abdelrazak Younes wrote:

Modified: lyx-devel/trunk/src/mathed/MathMacroTemplate.h
==============================================================================
+       MathMacroTemplate(Buffer * buf = 0);
  >  Modified: lyx-devel/trunk/src/mathed/MathParser.h
==============================================================================
  >  +bool mathed_parse_normal(MathAtom&, docstring const&,
  >  +               Parse::flags f = Parse::NORMAL, Buffer * buf = 0);

Why the default buf to 0? Shouldn't we enforce that?
In some parts of the code there is no way (that I know of) to get the
pointer to the buffer for which a MathHull inset is being created
(these are those corner cases I was speaking about). So what should
be the default? In those cases the buffer_ member is left 0, as it was
before this patch.

I am right now working on a patch to force Buffer passing in most InsetMath*.

OK, I did that... I am tired...

Please verify that macro works correctly whenever you have some time..
Abdel.

Reply via email to