On Fri, Dec 18, 2009 at 08:39:35PM +0100, Peter Kümmel wrote: > Enrico Forestieri wrote: > > On Fri, Dec 18, 2009 at 01:20:23PM +0100, [email protected] wrote: > > > >> Author: kuemmel > >> Date: Fri Dec 18 13:20:22 2009 > >> New Revision: 32579 > >> URL: http://www.lyx.org/trac/changeset/32579 > >> > >> Log: > >> Ticket 6266 Quoting Problem with QProcess: don't think we need any quotes > >> (at least on Linux) > > > > This commit is totally wrong. First, you do not distinguish between single- > > and double-quotes quoting, such that "this is quoted and a ' is in here" is > > not correctly parsed. Second, you cannot arbitrarily change characters > > because, if you have a filename containing a single quote, the converter > > will > > fail. Try to insert an xfig file named foo'09.fig and see what happens when > > you try to view dvi, postscript, or pdf. This was working before this > > commit. > > Please revert. > > > > Thanks, I didn't thought someone likes single quotes > in his filenames. I've reverted the Systemcall.cpp patch.
Thanks. I have also committed a patch such that file names can now also contain the double quote character. Note that on *nix you can use any character (except '/') in a file name. > configure.py should still be OK, because the quotes > the are du to spaces in filenames only, hope I'm not > totally wrong here, too. I don't use htlatex, so I really don't know. However, if the single quotes were meant for quoting the arguments and are not part of the htlatex syntax, then the configure.py patch should be correct (in this case, maybe you could have replaced the single quotes with double ones). I see that one of the arguments contain a '!' character, so when using a shell that should be escaped. Of course, this is not (should not be) the case with QProcess. If the single quotes were meant to quote the arguments, I wonder whether the htlatex converter ever worked on Windows, whose shell doesn't strip away single quotes. -- Enrico
