Pavel Sanda schreef:
[email protected] wrote:
Author: vfr
Date: Fri Jan  8 03:15:56 2010
New Revision: 32875
URL: http://www.lyx.org/trac/changeset/32875

Log:
Move reloadBuffer from GuiView to Buffer.

This fixes bug #6314: reloading master document makes emergencies of modified 
children.

Now also the version control handling could be moved to Buffer as well, and the 
hack in ensureBufferClean is removed.

+bool Buffer::reload()
+{
+       setBusy(true);
+       // e.g., read-only status could have changed due to version control
+       d->filename.refresh();
+       docstring const disp_fn = makeDisplayPath(d->filename.absFilename());
+
+       bool const success = loadLyXFile(d->filename);

hrrm. we used loadDocumend before. does it mean that features like scrolling to the position when the file was last closed is killed?

When do you want to restore the position then ? If you mean after a reload, this was already broken, and you can't get that right in general. You need the position in the file when it was saved. This is not necessarily related to the position before the reload or to the position when it was last closed.

there were also checks for file readability and its existence. this
is also bypassed?
These checks are still in Buffer::loadLyXFile(..).

Vincent

Reply via email to