On 01/08/2010 10:24 AM, Pavel Sanda wrote:
[email protected] wrote:
Author: rgheck
Date: Fri Jan  8 15:38:15 2010
New Revision: 32881
URL: http://www.lyx.org/trac/changeset/32881

Log:
Do not reload on check-in if check-in is cancelled.
-                       reloadBuffer();
+                       if (!msg.empty())
+                               reloadBuffer();
this is wrong. you can commit with empty message.

Sorry, I was mislead by this:

string LyXVC::checkIn()

{

LYXERR(Debug::LYXVC, "LyXVC: checkIn");

docstring response;

string log;

bool ok = Alert::askForText(response, _("LyX VC: Log Message"));

if (ok) {

if (response.empty())
response = _("(no log message)");
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

log = vcs->checkIn(to_utf8(response));

} else {

LYXERR(Debug::LYXVC, "LyXVC: user cancelled");

}

return log;

}


Guess we need a better return value.

Reply via email to