>The code update is still within InsetTabular::tabularFeatures(). Vincent >raised a valid issue about an inset creating new insets but here are my >thoughts: > >1. This inset is only creating and inserting a subset of itself. It also correctly >pops the cursor and places it between the two parts. >
I feel it's just not he task of a particular inset to insert other insets into the main document. Jmarc ? Do you have an opinion ? > All this using standard API calls so it is "safe". This makes no sense. You can do a lot of harm using cur.pop() and friends. > Please correct me: the lyx code currently doesn't have any place where insets, > in general, can be split. It could. For example, split a paragraph. What do you mean ? Of course we can split a paragraph. >Seems extraneous till you see that it can be bundled with split-table or split-equation >into a common LFUN_INSET_SPLIT (say). It would then be simpler to insert the >table-split code here and maintain Vincent's argument. Looks like a good idea to me. Vincent
