On 03/19/2010 02:11 PM, Vincent van Ravesteijn - TNW wrote:
Investigation of #6454 revealed that we are blinking the cursor even
when it is off screen, causing recalculations of paragraph metrics,
which may have weird side effects---such as #6454. Can someone please
stop the cursor from blinking when it isn't on the screen? At least
most of the time? I know nothing about this sort of thing.
This seems to do it. Anyone know a reason not to do this check here?
I don't know a reason not to do it, but you probably know my opinion
that it is just hiding other problems. One is that determining whether
the cursor is at the RTL boundary or not should not be dependent on the
view and the breaking of the paragraphs. But well, that has been
introduced by my own commit, so.... There is no need to get it perfect
right now.
This is kind of independent of the other issue, though it was revealed
by my and Dov's testing. It just seems a waste to be doing all the
calculations in showCursor() if we don't actually get to see it. And I
worry that there might be other oddities that result from that.
I'm glad you helped figuring out where the problem was and that it gets
fixed in the next release.
Thanks.
rh
