On 07/21/2010 09:57 AM, Vincent van Ravesteijn wrote:
Modified: lyx-devel/trunk/src/Buffer.h
==============================================================================
--- lyx-devel/trunk/src/Buffer.h Wed Jul 21 06:59:05 2010 (r34992)
+++ lyx-devel/trunk/src/Buffer.h Wed Jul 21 15:19:52 2010 (r34993)
@@ -427,7 +427,7 @@
// Macro handling
//
/// Collect macro definitions in paragraphs
- void updateMacros() const;
+ void updateMacros(bool record_docit = false) const;
/// Iterate through the whole buffer and try to resolve macros
void updateMacroInstances() const;
I don't like adding a parameter to updateMacros() for one very
specific rarely used usecase.
I have an idea about this now. I didn't like it either, but didn't see
what else to do.
+ if (!isClone())
+ thePreviews().removeLoader(*this);
It looks wrong to depend on isClone().
I think this is right, though of course I may be mistaken. If the buffer
is cloned, then, actually, we shouldn't attempt to load previews, etc,
anyway. I was about to ask about this, as I'm not sure what the best way
to suppress them would be.
+ // For XHTML image export, we need to control the background
+ // color here.
+ ColorCode bg = buffer_.isClone()
+ ? Color_white : PreviewLoader::backgroundColor();
Dito. It's strange to conclude we are exporting XHTML because the
buffer is a clone.
You're right. For one thing, we might be exporting without being in a
clone, if that had been turned off.
There is no comment at all that describes the "wait" and
"record_docit" parameters.
I've added one for wait. The other will vanish.
rh
