>+ /// are we hovering something that we can click
>+ bool clickableinset_;
>
I would prefer "bool clickable_inset_;".
> void BufferView::updateHoveredInset() const
> {
>+ d->clickableinset_ = false;
>+
[...]
>+
>+ if (covering_inset && covering_inset->asInsetCollapsable()) {
>+ FuncRequest fr = FuncRequest(LFUN_NOACTION, x, y,
>mouse_button::none);
FuncRequest fr(LFUN_NOACTION, x, y, mouse_button::none);
>+ d->clickableinset_ = static_cast<InsetCollapsable const
>*>(covering_inset)->hitButton(fr);
>+ } else if (covering_inset && covering_inset->hasSettings())
>+ d->clickableinset_ = true;
>+
This still fails for InsetTabular as it is not clickable (in the
current sense), but does have settings.
There is now a function Inset::clickable(x, y) that you can use. This
then becomes:
d->clickable_inset_ = covering_inset && covering_inset->clickable(x, y);
Another point is that if for some reason the Inset moves or gets
deleted while the fingerpointing cursor is there, the mouse cursor is
not updated.
Vincent
