On Mon, Oct 25, 2010 at 3:55 PM, Jürgen Spitzmüller <sp...@lyx.org> wrote:
> Please let me know of other issues. Note particularly that all fixes that
> entail a string change should go in very soon, since we will turn to string
> freeze soon.

Well this string change doesn't affect branch, but I think we should
rename Invisible as Hidden|H in the View menu as:
1) This allows a natural keyboard accelerator "H" ("I" is already used).
2) This matches the terminology "Hide tab" used in the context menu
when hiding the tab.

-- 
John C. McCabe-Dansted
Index: frontends/qt4/Menus.cpp
===================================================================
--- frontends/qt4/Menus.cpp     (revision 35426)
+++ frontends/qt4/Menus.cpp     (working copy)
@@ -879,8 +879,8 @@

 void MenuDefinition::expandDocuments()
 {
-       MenuItem item(MenuItem::Submenu, qt_("Invisible"));
-       item.setSubmenu(MenuDefinition(qt_("Invisible")));
+       MenuItem item(MenuItem::Submenu, qt_("Hidden|H"));
+       item.setSubmenu(MenuDefinition(qt_("Hidden|H")));

        Buffer * first = theBufferList().first();
        if (first) {

Reply via email to