Pavel Sanda wrote: > Georg Baum wrote: >> I see. That means that this code is unrelated. >> >> > the only exception is argument "on" (which was previously used in >> > menu) so insert was possible only from text mode. >> >> Why previously? It is still used. And why is insert nowadays also >> possible from math mode? This is exactly the problem. A correct fix for >> bug 6709 and related problems would IMHO look like the attached. What is >> wrong with it? > > iirc because Uwe decided to 'fix' menu so ctrl+m shortcut is visible for > entering math mode. as usual the change was not discussed at all and my > reply to that commit was left without any reaction on his side :)
Ah, I see. So "previously" meant the use for the inline formula, all other formulas still use "on". After thinking again about this I came to the following conclusions: - Labeling the lfun "math-mode" as "Insert Math->Inline Formula" is wrong. "math-mode" does not only insert a formula, but toggles between text and math mode. Therefore, the correct lfun for this entry is "math-mode on", which is also used in 1.6. - Having no shortcut for "math-mode on" is certainly not nice. I would suggest to transfer one of the three shortcuts for "math-mode" (C-M, M-C M, M-M M) to "math-mode on", but I don't know which one. - So far, there is no known reason to allow "math-mode on" in math. Therefore I am going to put the patch (+ some comments) in. Georg
