On Tue, Apr 05, 2011 at 05:06:44PM +0200, Enrico Forestieri wrote: > On Tue, Apr 05, 2011 at 09:45:27AM +0200, Vincent van Ravesteijn wrote: > > > > >Modified: lyx-devel/trunk/src/frontends/qt4/GuiErrorList.cpp > > >============================================================================== > > >+ // Don't try to highlight the content of info insets > > >+ while (dit.inset().lyxCode() == INFO_CODE) > > >+ dit.backwardPos(); > > >+ > > > > It feels wrong that GuiErrorList has to know about specific insets > > and that it leads to a crash otherwise. > > > > Shouldn't this be part of the DocIterator/Cursor class instead ? > > Still, it would probably need to ask Inset for some property rather > > than introducing a special case for InfoInsets. > > I had already tried that, but discovered that asking for editability, > for example, was not implemented consistently in all insets. > It was some time ago and now I don't remember the details.
Nevertheless, I tested it again with all trouble cases I know of and didn't see any problem, so I did it that way. Not sure what problem I was experiencing with the editable() check. Let's see what happens. -- Enrico
