On Thu, Apr 21, 2011 at 08:22:05PM -0400, Richard Heck wrote: > Not that I'm intending to commit this soon, but I thought I'd post > this patch now for comment and commit shortly after 2.0. This patch > un-mutables most of the mutable members of OutputParams. A couple > remain: encoding, which maybe should be mutable, and inulemcmd, > which I'm less sure about, though maybe it should be too. Anyway, > comments welcome.
You don't explain the logic of your patch. A quick glance (I have no time right now to go deeply into it) seems to suggest that you simply make a non-const copy of OutputParams and pass that down the chain, such that now the members can be freely changed. However, on return, the changed values are not returned back to the caller. Are you sure this is OK? I mean, are you sure that the info carried by the changed members is not used in other places of the code? -- Enrico
