On 2011-09-18, Enrico Forestieri wrote: > On Sun, Sep 18, 2011 at 06:20:24PM +0200, Stephan Witt wrote:
>> That's not 100% correct. It does the change for all matching text. >> With your patch applied, when changing from default to German for a mixed >> document (some parts in German some parts default) and changing again to >> English all German text (including the explicitly marked parts) is changed >> to English. > Yes, that's correct, me thinks. Indeed, the parts in German that were > underlined now are no more underlined. So, if you change language again > you know that they will be updated. > Maybe this was the intent of that check or maybe not. Maybe the check could be narrowed down to this case: if there is text explicitely marked in the new document language, ask the user whether to keep this explicit markup or set it to the default language. This should prevent accidential use of information but limit annoying questions. > Anyway, I'm giving up > as it is clear that there isn't consensus about the patch. Please, don't give up. Günter
