On Fri, Oct 28, 2011 at 12:18:02PM +0000, Julien Rioux wrote:
> Enrico Forestieri <forenr <at> lyx.org> writes:
> 
> > 
> > On Wed, Oct 26, 2011 at 12:04:08PM +0000, Julien Rioux wrote:
> > > 
> > > The real issue are all the converters using python.
> > 
> > The attached patch should also take care of that.
> > 
> 
> 
> The patch does not compile, you need #include "support/debug.h" at the top.

Uh... sorry. I only tried it on windows and debug.h is already included
by the platform specific code, so I didn't notice that.

> The detection works well.
> 
> The magic replacement of "python -tt" is very hackish we should probably make 
> it
> a proper "token", maybe $$p. For example I change "python -t" and it breaks. 
> In
> certain cases maybe I really mean to use python 3 for a particular converter,
> yet internally we change this call to a python 2 interpreter. It's not
> transparent at all to the user that when they write the magic string "python
> -tt", LyX will find and call a python 2 interpreter, but when you change the
> string a bit, LyX will not do anything special to it anymore.

Please, feel free to improve it. My reasoning was along the line of:
as "python -tt" is our standard python invocation, we have to make sure
of calling the right python only in this case. If a user wants to try
another python, he can always invoke it as python3 or whatever different
from "python -tt".

-- 
Enrico

Reply via email to