On 11/18/2011 05:36 PM, Vincent van Ravesteijn wrote:
> Op 18-11-2011 22:34, [email protected] schreef:
>> Author: rgheck
>> Date: Fri Nov 18 22:34:40 2011
>> New Revision: 40212
>> URL: http://www.lyx.org/trac/changeset/40212
>>
>> Log:
>> Fix bug #7873. Patch is sufficiently explanatory.
>
> The patch isn't explanatory enough that I would guess that this fixes
> a crash when changing labelwidth.
>
Sorry, I often assume it's enough to reference the bug rather than
including a comment about what the bug was in the patch. I'll try to
remember not to do that. What I meant was that, once you know what the
bug was, you'll understand what the fix was.
It would be nice to be able update log messages....
Richard
>>
>> Modified:
>> lyx-devel/trunk/src/Text2.cpp
>>
>> Modified: lyx-devel/trunk/src/Text2.cpp
>> ==============================================================================
>>
>> --- lyx-devel/trunk/src/Text2.cpp Fri Nov 18 21:48:54 2011
>> (r40211)
>> +++ lyx-devel/trunk/src/Text2.cpp Fri Nov 18 22:34:40 2011
>> (r40212)
>> @@ -445,8 +445,11 @@
>> depth_type const depth = pars_[offset].getDepth();
>> Layout const& layout = pars_[offset].layout();
>> for (pit_type pit = offset; pit != end; ++pit) {
>> - while (pars_[pit].getDepth()> depth)
>> + while (pars_[pit].getDepth()> depth) {
>> ++pit;
>> + if (pit == end)
>> + return;
>> + }
>> if (pars_[pit].getDepth()< depth)
>> return;
>> if (pars_[pit].layout() != layout)
