On Thursday 07 December 2000 13:53, Dekel Tsur wrote:
> On Thu, Dec 07, 2000 at 11:04:17AM +0000, Angus Leeming wrote:
> > Third time lucky! Not Dispatch(...CREATE) but Dispatch(..INSERT)
> > Sorry,
> > A
> >
> > On Thursday 07 December 2000 11:00, Angus Leeming wrote:
> > Sorry, got that wrong. The inserted code should be under
> > LFUN_CITATION_CREATE of couse and would simply bypass the createCitation
> > call:
>
> Why do you need both LFUN_CITATION_CREATE and LFUN_CITATION_INSERT ?
> It is possible to combine this two cases into one (this is what is done
> with references). Of cource. the citation dialog should't do call to
> dispatch(LFUN_CITATION_INSERT, ..) with an empty second argument.
LFUN_CITATION_CREATE:
called from the minibuffer citation-insert foo
called from Insert->Citatation reference
LFUN_CITATION_INSERT:
called from FormCitation::apply()
Ideally, minibuffer citation-insert foo would call LFUN_CITATION_INSERT, but
the string passed has a different format to that passed from
FormCitation::apply(). Could change the string passed from the minibuffer,
but would then also have to edit the sources of pybibliographer which
emulates the minibuffer here.
Of course, if you want to do that...
Angus
