27/05/2013 22:18, Vincent van Ravesteijn:
I tested the branch a bit more.
- When you just implemented this, my LyX was translated immediately, but
now it can't find the translations anymore. This is a pity.
I don't really understand the following:
+ if (in_build_dir_)
+ return FileName(top_srcdir().absFileName() + "/po/"
+ + c + ".gmo");
So, if we run in the build dir, we look for the gmo files in the source
dir ? Shouldn't we be looking the build dir then ? What about the
attached ?
Traditionally, autotools put the .gmo files in the source directory. The
reason is that these files are distributed in the tar.gz file, so that
users do not need gettext to compile LyX.
It seems that cmake does not follow this rule. Does this mean that .gmo
files are not distributed?
I would be OK with either having cmake generate gmo file in source or
have special code in Package.cpp to catter for different build systems.
- I get an error that the language C could not be found. I know this is
logical when the po-files can't be found, but it is a bit confusing that
the language is "C".
This is related to this code snippet in the current code:
// Find the code we have for a given language code. Return empty if not
found.
string realCode(string const & c)
{
// Qt tries to outsmart us and transforms en_US to C.
string code = (c == "C") ? "en" : c;
Instead of doing that in the realCode() function, we could just change
the setting of the lang_ member.
JMarc
