Am 31.05.2013 um 14:14 schrieb Uwe Stöhr <uwesto...@web.de>:
> Am 31.05.2013 09:14, schrieb Stephan Witt:
>
>> Uwe, please test if it works for you.
>
> LyX does currently not compile.
Here I can compile it.
> But I think your change was inncomplete because:
>
>>> configure_command_ = os::python() + ' ' +
>>> quoteName(configure_script.toFilesystemEncoding(),
>>> quote_python) +
>
> here we have the quote_python tag so we should it have here too:
>
>>> +
>>> quoteName(FileName(binary_dir().absFileName()).toFilesystemEncoding());
>
> So I would assume that
>
> quoteName(FileName(binary_dir().absFileName()).toFilesystemEncoding(),
> quote_python);
>
> is correct.
>
> regards Uwe
This is from src/support/filetools.h:
/// How to quote a filename
enum quote_style {
/** Quote for the (OS dependant) shell. This is needed for command
line arguments of subprocesses. */
quote_shell,
/** Quote for python. Use this if you want to store a filename in a
python script. Example: \code
os << "infile = " << quoteName(filename) << '\\n';
\endcode This uses double quotes, so that you can also use this
to quote filenames as part of a string if the string is quoted
with single quotes. */
quote_python
};
I read it so one should use quote_shell for shell command arguments.
Why then the first quote_python is used? I think it's wrong.
configure_command_ is a shell command AFAIKS.
Stephan
