Re: [PATCH] LFUN_DOWN: if cursor is on last line, move to end

[Stephan Witt]

Am 20.06.2013 um 16:09 schrieb Jean-Marc Lasgouttes <lasgout...@lyx.org>:

> 20/06/2013 13:01, Stephan Witt:
>> Am 20.06.2013 um 12:33 schrieb Stephan Witt <st.w...@gmx.net>:
>> 
>>> Am 20.06.2013 um 10:37 schrieb Jean-Marc Lasgouttes <lasgout...@lyx.org>:
>>> 
>>>> What does OSX do?
>>> 
>>> It moves to the very end of the last paragraph and does the same while 
>>> extending the selection.
>>> 
>>>> This could be part of our mac-like cursor handling.
>>> 
>>> Yes, indeed. It should be part of it, IMHO.
>> 
>> This patch would do it. It's a replacement of Scott's patch.
> 
> I like the patch. Tow remarks:
> 
> * be acreful about indetation, use tabs instead of spaces

I'll correct this… if I do the changes with Xcode it's always wrong.

> 
> * are you sure that the nested if() do the right thing in all cases?

Yes. Originally it was:

if (!atFirstOrLastRow) {
 do_something();
}

now it is:

if (atFirstOrLastRow) {
 if (lyxrc.mac_like_cursor_movement) {
  scotts_doing();
 }
 // do nothing - Pavels preference
} else {
 do_something();
}

Ok?

Stephan