On Sun, Jul 14, 2013 at 3:37 PM, Pavel Sanda <[email protected]> wrote: > Scott Kostyshak wrote: >> On Sun, Jul 14, 2013 at 2:58 PM, Pavel Sanda <[email protected]> wrote: >> >> > Often before any package is installed the package is tested by make check. >> > To me, there is no reasonable way how to allow LyX run tex2lyx checks >> > _before_ it is installed because as you correctly say configure needs to >> > be run first. >> >> The way I solve this is I run the export tests first. Then the tex2lyx >> tests work for me. Or you could run just one export test and that >> should work too. > > Does this runs configure in backgrounds? You don't want to mess up > with root home directory (creating ~/.lyx).
It does run configure. >> > I can explicitly forbid test phase in install scripts but it is not >> > standard and our approach should be to disable tex2lyx test instead >> > (it was not there in 2.0, in fact we add lot of tests in 2.1 as I saw). >> > I'm not sure what is the practise of _maintainers_ in binary distros >> > but if they are responsible they run make check as well and that will fail. >> >> were available? I guess that a responsible maintainer would install >> all libraries that the tests depend on so that all tests would be run? > > Then you need to explicitly state what needs to be installed (should > we really ask for e.g. gnumeric; should we ask for bunch of esoteric > latex classes?) so he adds it to dependencies. > The question is whether we want these tex2lyx test for _us_ to make sure > we didn't break thing by development or eveything is fine on the target > machine. In the second case is missing gnumeric bug or not? Good distinction. I do think that we should take responsibility for regressions in our code. However, it's hard to test for platform-specific regressions. I think that I and Kornel are the only ones that try to run all of the tests. And I think both of us are on (K?)ubuntu. All of the combinations of different libraries, operating systems, TeX Live versions create a complicated testing area to cover. In theory, we should take responsibility for testing on all but in practice we do not. I agree that the tests should be to make sure everything is fine on the target machine. But if a maintainer really wants to know whether LyX-Gnumeric integration will work for the users on that distro, then yes he/she has to install Gnumeric. I guess the best thing to do is what you say -- explicitly state all of the dependencies. But what is the best way to do that? If you do not exit with error when a dependency is missing, it is possible that a maintainer will not look any further. Perhaps the best thing to do is to not exit with error but write warnings of missing test dependencies to STDERR? Scott
