On Mon, Aug 5, 2013 at 7:48 AM, Kornel Benko <[email protected]> wrote: > Am Montag, 5. August 2013 um 07:41:31, schrieb Scott Kostyshak > <[email protected]> > >> On Mon, Aug 5, 2013 at 7:34 AM, Kornel Benko <[email protected]> wrote: > >> > Am Montag, 5. August 2013 um 07:07:58, schrieb Scott Kostyshak > >> > <[email protected]> > >> > > >> >> On Mon, Aug 5, 2013 at 6:02 AM, Vincent van Ravesteijn <[email protected]> > >> >> wrote: > >> > > >> > [snip] > >> > > >> >> > As far as I see it, it cannot happen that there is no > >> >> > default_output_format. > >> > > >> >> > >> > > >> >> > Only if there are lyx files with an old file format. In that case: > >> > > >> >> > > >> > > >> >> > - a) we should update all lyx docs to the latest format anyway; > >> > > >> >> > - b) we can just check for the fileformat to see whether it has the > >> >> > latest > >> > > >> >> > format; > >> > > >> >> > - c) we can assume "default" when there is no >> >> > "default_output_format". > >> > > >> >> > >> > > >> >> The attached patch implements c): If no 'default_output_format' is > >> > > >> >> found, then we assume 'default'. > >> > > >> >> > >> > > >> >> Is it OK? > >> > > >> > > >> > > >> > I would use a extra list-variable for this. > >> > > >> > set(out_formats "xhtml" "pdf" "pdf2" "pdf5") > >> > > >> > set(${varname} ${out_formats}) > >> > > >> > > >> > > >> > and reuse it > >> > > >> > if(CMAKE_MATCH_1 STREQUAL "default") > >> > > >> > set(found ${out_formats}) > >> > >> Thank you. Attached is the new patch. > >> > >> Scott > > > > +1 > >
I committed at 1d3e77b. Vincent suggested it, Kornel improved and +1'ed it. Scott
