On Sat, Feb 15, 2014 at 8:33 PM, Richard Heck <[email protected]> wrote: > On 02/15/2014 08:02 PM, Scott Kostyshak wrote: >> >> On Sat, Feb 15, 2014 at 7:39 PM, José Matos <[email protected]> wrote: >>> >>> On Friday 14 February 2014 21:45:11 Scott Kostyshak wrote: >>>> >>>> This patch was mistakenly posted on a Github account: >>>> >>>> https://github.com/djmitche/lyx/commit/09632fab35acf9d1a7003a4055f7638ed2b613d9 >>>> >>>> The author's email is on his Github page. >>>> >>>> Is this something to look at or forget? >>>> >>>> Scott >>> >>> To look at, universal newlines are supported in python since python 2.3 >>> and the minimum version that we support is python 2.4 so it is safe. >> >> Thanks for taking a look, José. Do you mean safe to commit or safe >> meaning we don't need it now? > > > He means safe to commit. > > >> If commit, would you recommend for 2.1 if Vincent approves? > > > I would say it was fine for trunk and branch.
Sounds good. I will commit to both branch and trunk tomorrow. Thanks, Scott
