On 13/03/2015 15:21, Jean-Marc Lasgouttes wrote:
Le 13/03/2015 12:10, Jean-Marc Lasgouttes a écrit :
In this patch, I change our new LyX logo inset to look like the real
thing. Georg, is there a reason why your chose not to follow this route
(or only lack of time/motivation).
Also, I am not sure that the Color_special color is the best choice (try
to load the Intro manual, for example). Would it be a problem to use
normal color once it is clear that the logo is something special, not
plain text?
With this new patch all logos are logoified and the color is the
normal plain one.
Comments?
You use lots of hardcoded constants nobody except you will understand 1
month from now, and not even you 1 year from now :-P
At least those are used 4 times and should use meaningfully named
constants: 0.16667 and 0.125.
Nitpick: 0.16667 ~= 1/6 so if you want to be more accurate you'd better
use division per 6.
Nitpick 2: You are using floating point calculation while you could
fixed point calculation easily. Not a problem on PC but on some ARM
systems (eg older Raspberry Pi).
My 2 cts of the year :-)
Abdel.
