On 05/12/2015 05:06 AM, Jean-Marc Lasgouttes wrote:
Hi Richard,

Coverity points out that these two methods pass XHTMLStream and Toc objects by value and not by address. Is this intentional? It seems hazardous, especially in the XHTMLStream case.

    ///
void makeTOCWithDepth(XHTMLStream xs, Toc toc, const OutputParams & op) const;
    ///
void makeTOCNoDepth(XHTMLStream xs, Toc toc, const OutputParams & op) const;

No, definitely an oversight. It works only because the output stream containined in XHTMLStream is a reference.

I'll fix it.

Richard

Reply via email to