Am 15.05.2015 um 16:40 schrieb Kornel Benko <kor...@lyx.org>:

> Am Freitag, 15. Mai 2015 um 16:31:05, schrieb Stephan Witt <st.w...@gmx.net>
>> Am 15.05.2015 um 15:46 schrieb Stephan Witt <st.w...@gmx.net>:
>> 
>>> Am 15.05.2015 um 14:49 schrieb Enrico Forestieri <for...@lyx.org>:
>>> 
>>>> On Fri, May 15, 2015 at 12:04:50PM +0200, Stephan Witt wrote:
>>>>> 
>>>>> I'll try to get it running on Linux to see how it works there. Meanwhile,
>>>>> I'm interested in comments.
>>>> 
>>>> Please, don't pass back and forth QPixmap objects on the stack. These
>>>> are big objects, potentially. Instead, use
>>>> 
>>>> bool getPixmap(QString const & path, QPixmap & pm)
>>>> {
>>>>    // deal with QPixmap
>>>> 
>>>>    return !pm.isNull();
>>>> }
>>> 
>>> Ok, thank you. I'll change it.
>> 
>> This results in the following patch - if you had something like that in mind 
>> I'll
>> split it in two patches. The other getPixmap method with QPixmap result was 
>> already there.
>> 
>> Stephan
> 
> Compile error with this patch.

That's no surprise. The method I've changed is used in conditionally compiled 
code. 
Attached is an updated patch.

Stephan

Attachment: 0004-svg-hidpi-on-mac.patch
Description: Binary data

Reply via email to