Miyata Shigeru <[EMAIL PROTECTED]> writes:
| > To me it look good and certainly a step in the right direction.
| >
| > I have so far only looked at the diff.
|
| Anything else?
|
| For example, I'd like to know your opinion on system_tempdir.
| I thought it not very comfortable to declare a global variable as
| extern in many files, so I put it into class os, although the
| handling it was independent of OS's.
Agree. Perhaps we should have an container/struct "Globals" that take
care of this stuff. Just to separate it from the "Os".
| Also os::init() is called from other os:: methods in the OS/2
| implementation and currently I use a hackish check for (argc != 0)
| to avoid multiple initialization in addition to static bool initialized.
| Is there any better way?
Why do you need the argc check?
(and isn't argc always !0?)
void init() {
static initialized = false;
if (!initialized) {
// stuff
}
}
Isn't that enough?
Lgb
