Am Freitag, 12. Februar 2016 um 20:08:49, schrieb Georg Baum <[email protected]> > Jean-Marc Lasgouttes wrote: > > > Le 11/02/2016 21:40, Georg Baum a écrit : > >> Comparing the complete 3rdparty directory from the tar ball with the one > >> in git shows also that some boost files are missing (see attached). > >> However, on linux building with included boost works even without these > >> files, so I think that removing them from git is better than adding them > >> to the build boost (except for the license of course). > > > > > > icu.* is for implementing unicode regex on top of ICU. We can get rid of > > it, but I guess that it will return every time we update boost. So it > > might be easier to keep it. > > > > usinstances.cpp is MSVC only. Are we sure that we do not need it? > > Good point. > > > wc_regex_traits.cpp Implements out of line members for > > c_regex_traits<wchar_t>. Might it be useful in some settings? > > Dunno. If I understand 3rdparty/boost/libs/regex/CMakeLists.txt correctly > then none of the three files is built, so I would guess that all can be > removed (i.e. beta2 could be relased without further modifications, the > removal could be done later). However, I am not good in cmake speak at all, > so I might be wrong.
I understand it the same way as you.
> We have basically two options:
>
> 1) Add all files to the tar ball (either like it was done by my patch, or by
> adding them to EXTRA_DIST so that they are not needlessly compiled on
> linux).
>
> 2) Have a cmake expert or somebody with access to MSVC try out which files
> are needed and which can be removed, and then only add the needed ones.
>
They do not harm, still I would remove them.
> Scott, I guess it is your call;-)
>
>
> Georg
Kornel
signature.asc
Description: This is a digitally signed message part.
