Re: Tarballs for LyX 2.2.0 are on FTP

[Scott Kostyshak]

On Wed, May 25, 2016 at 12:29:04AM +0200, Uwe Stöhr wrote:
> Am 24.05.2016 um 04:32 schrieb Scott Kostyshak:
> 
> > As usual I'll wait before announcing the release until after uploading
> > the binaries and providing some time for the mirrors.
> 
> Great job Scott! Many thanks for all your patient work.
> 
> I built it now and noticed 2 things:
> 
> - There is a dataloss warning that should be fixed before the final release:
> 
> D:\LyXGit\LyX22\src\insets\InsetSeparator.cpp(213): warning C4244: '+=':
> conversion from 'double' to 'int', possible loss of data

Thanks for finding this. I agree with Richard that it is not urgent.

> Guillaume could you please have a look?

Does Guillaume seem so bored? :)
Unless I misunderstood, the code was introduced at d4ca8d74.

Looking at the code, there are explicit conversions to int a few lines
down and a few lines up, so a conversion to int is probably intended
here also. Attached is a patch.

> - There is no batch build script for building LyX 2.2 with MSVC 2015. May I
> add one?
> 
> Despite of the warning the compilation run fine and I have an installer
> ready.

Good news! I think we can move forward with the installer despite the
warning you discovered.

Scott

> Concerning the installer: The MiKTeX maintainer works hard to iron out some
> long standing bugs and thus releases currently almost every day a new
> version. Unfortunately he did not yet release a new installer so that new
> installations of MiKTeX and LyX will require at least 3 update cycles to be
> up to date. I try to convince him for a new installer. If this is not
> possible, I would like to release a new installer as soon as the MiKTeX
> installer is available.
> 
> best regards Uwe

diff --git a/src/insets/InsetSeparator.cpp b/src/insets/InsetSeparator.cpp
index a759f1f..27aeb7c 100644
--- a/src/insets/InsetSeparator.cpp
+++ b/src/insets/InsetSeparator.cpp
@@ -210,7 +210,7 @@ void InsetSeparator::draw(PainterInfo & pi, int x, int y) 
const
                pi.pain.lines(xp, yp, 2, ColorName());
 
                if (params_.kind == InsetSeparatorParams::PARBREAK) {
-                       yp[0] += 0.25 * asc * 0.75;
+                       yp[0] += int(0.25 * asc * 0.75);
                        yp[1] = yp[0];
                        pi.pain.lines(xp, yp, 2, ColorName());
                }

signature.asc
Description: PGP signature