On 06/25/2016 03:56 PM, Georg Baum wrote: > I recently stumbled upon > > using std::shared_ptr; > > or > > lyx::support::FileName; > > in header files (e.g. TocBackend.h). The shared_ptr was introduced as part > of the lyx::shared_ptr removal (which did either point to boost or std), but > there are other hits as well. While I understand that in this particular > case the "using" statement avoided other changes in the headers, I consider > it dangerous to have "using" statements in header files in general: > > using foo::bar > > effectively forbids to use the name 'bar' in any other namespace in the > whole program, since simply adding or removing an #include of the > corresponding header subtly changes the name lookup. Therefore I'd like to > remove these using statements. OK?
+1 rh
