Am Mittwoch, 3. Mai 2017 um 10:08:40, schrieb Jean-Marc Lasgouttes <lasgout...@lyx.org> > Le 03/05/2017 à 10:05, Kornel Benko a écrit : > > Am Mittwoch, 3. Mai 2017 um 09:41:08, schrieb Jean-Marc Lasgouttes > > <lasgout...@lyx.org> > >> Le 03/05/2017 à 07:48, Stephan Witt a écrit : > >>> Something like the attached patch is needed!? > >> > >> Yes, I just did that. > >> > >> JMarc > > > > You did, but without test. > > # ctest -R findadv > > ... > > 10% tests passed, 26 tests failed out of 29 > > Indeed, because those tests are cmake based, and I am not. > > I can revert, but this gives us something the does not compile. Does it > compile with cmake? Why?
It did not compile. > I would be surprised to hear that my commit did kill the tests, but I > learn every day! > > Could you try to revert locally and see what happens? Reverted now fa146a0ffe431ce239851fc20986e3052127f33a and 8c10182962efa643edfcfbe64fc830b5fc0d9a65 # ctest -R findadv-01 ==> Failed too (crashes lyx) Testing manually, I see, that replace is not working. (E.g. findadv does not find anything) Hm, test passes after reverting also 3610cdf66944dc790e2e3df666e99f33c45b1ede > JMarc Kornel
signature.asc
Description: This is a digitally signed message part.