I reviewed the PDF viewers LyX is searching for. It turned out that the last stable version of KGhostView and KPDF were released 9 years ago, so I think we could remove their support.

Under Linux I was looking for a PDF program with which I can properly fill out and submit PDF forms. I found the Program Master PDF editor and would therefore like to support it in LyX.

I also found out that "ghostview" is deprecated since years and gv, gsview64 and gsview32 are the replacements (which we already support).

So the attached patch removes to check for ghostview, KPDF and KGhostView and adds to check for masterpdfeditor.

Could this go in or are there any reasons against this?

thanks and regards
Uwe
diff --git 
"a/C:\\Users\\Usti\\AppData\\Local\\Temp\\TortoiseGit\\configure-189ed7d.000.py"
 "b/D:\\LyXGit\\Master\\lib\\configure.py"
index 8e7fedbb5a..f03d2e08f4 100644
--- 
"a/C:\\Users\\Usti\\AppData\\Local\\Temp\\TortoiseGit\\configure-189ed7d.000.py"
+++ "b/D:\\LyXGit\\Master\\lib\\configure.py"
@@ -675,9 +675,7 @@ def checkFormatEntries(dtl_tools):
     #checkProg('a Postscript interpreter', ['gs'],
     #  rc_entry = [ r'\ps_command "%%"' ])
     checkViewer('a Postscript previewer',
-                ['kghostview', 'okular', 'qpdfview --unique',
-                 'evince', 'xreader',
-                 'gv', 'ghostview -swap', 'gsview64', 'gsview32'],
+                ['okular', 'evince', 'qpdfview --unique', 'gv', 'gsview64', 
'gsview32'],
         rc_entry = [r'''\Format eps        eps     EPS                    "" 
"%%"      ""      "vector"        "image/x-eps"
 \Format eps2       eps    "EPS (uncropped)"       "" "%%"      ""      
"vector"        ""
 \Format eps3       eps    "EPS (cropped)"         "" "%%"      ""      
"document"      ""
@@ -686,10 +684,8 @@ def checkFormatEntries(dtl_tools):
     # maybe use "bestApplication()" from 
https://github.com/jleclanche/python-mime
     # the MIME type is set for pdf6, because that one needs to be 
autodetectable by libmime
     checkViewer('a PDF previewer',
-                ['pdfview', 'kpdf', 'okular', 'qpdfview --unique',
-                 'evince', 'xreader', 'kghostview', 'xpdf', 'SumatraPDF',
-                 'acrobat', 'acroread', 'mupdf',
-                 'gv', 'ghostview', 'AcroRd32', 'gsview64', 'gsview32'],
+                ['pdfview', 'okular', 'evince', 'qpdfview --unique', 'xpdf', 
'SumatraPDF', 'acrobat', 'acroread',
+                 'masterpdfeditor4', 'mupdf', 'gv', 'AcroRd32', 'gsview64', 
'gsview32'],
         rc_entry = [r'''\Format pdf        pdf    "PDF (ps2pdf)"          P  
"%%"      ""      "document,vector,menu=export"   ""
 \Format pdf2       pdf    "PDF (pdflatex)"        F  "%%"      ""      
"document,vector,menu=export"   ""
 \Format pdf3       pdf    "PDF (dvipdfm)"         m  "%%"      ""      
"document,vector,menu=export"   ""

Reply via email to