Re: Can't cancel suggestion context menu

[Pavel Sanda]

On Thu, Nov 29, 2018 at 01:33:17PM +0100, Pavel Sanda wrote:
> On Wed, Nov 28, 2018 at 04:01:24PM +0100, Kornel Benko wrote:
> > Am Montag, 26. November 2018 17:45:41 CET schrieb Pavel Sanda 
> > <sa...@lyx.org>:
> > > Hi,
> > > 
> > > have english dictionary on, write "traces", leave cursor at the end of 
> > > the work,
> > > hit tab. Context menu with suggestions appears. When I pres Esc, the 
> > > context menu
> > > won't disappear. Is this expected?
> > > 
> > > Pavel
> > > 
> > 
> > Sorry, cannot reproduce on master. Neither with master nor with stable.
> > I probably have not understood the procedure ...
> 
> Because the recipy was not full, other suggestions needs to be in the buffer 
> first, type:
> 
> tracesi tracesu traces
> 
> and hit tab after last "s". You should see contex menu with first two words 
> as suggestions
> appearing and it won't disappear after Esc.

Patch fixing the issue is attached; we simply did not have handler for Esc.
Will commit soon unless anyone objects.

Pavel

diff --git a/src/frontends/qt4/GuiCompleter.cpp 
b/src/frontends/qt4/GuiCompleter.cpp
index f2e4eda81f..767bb6bac7 100644
--- a/src/frontends/qt4/GuiCompleter.cpp
+++ b/src/frontends/qt4/GuiCompleter.cpp
@@ -216,6 +216,11 @@ bool GuiCompleter::eventFilter(QObject * watched, QEvent * 
e)
                        tab();
                        ke->accept();
                        return true;
+               case Qt::Key_Escape:
+                       hidePopup();
+                       hideInline();
+                       updateVisibility(false, false);
+                       return true;
                default: break;
                }
        }