On Friday 16 March 2001 15:29, John Levon wrote:
> On Fri, 16 Mar 2001 [EMAIL PROTECTED] wrote:
> This was not checking for form && form->visible in the WMHideCB ??
> Odd that it didn't happen at home ...
No. This was me. FormMaths ultimately derives from FormBaseDeprecated, not
FormBase anymore. Since the close button sent a calback to
C_FormBaseCancelCB, this resulted in a pile of rubbish!
> is the other one my bug was well ?
Who knows!
> Also, why did you move most of the callback logic into member functions ?
> How is this better ? It just looks like more lines of code to me !
The extern "C" callbacks are meant to be very simple wrappers for "real" C++
functions. In the past we did this with a macro, but that buggered up Lars'
debugger. The principle behind the macros is still valid, however.
Basically, we need them because xforms is written in C but that doesn't mean
we like them!
Anyway, the methods are not static, so you get rid of all that form->xyz
stuff.
> And why move the static chars up to the top of the file ?
> I would prefer them near their actual use personally (even better is to
> not have them at all of course)
I was just trying to get the thing to compile. Put them where you like.
Angus
