Le 1 janvier 2019 05:22:08 GMT+01:00, Scott Kostyshak <[email protected]> a écrit : >When compiling master with clang, I get a lot of warnings. Almost all >of >them are from -Winconsistent-missing-override. Are these worth >addressing? There is also one warning from -Woverloaded-virtual. > >My build long is attached. > >Scott
Yes, we should fix them. Luckily, this mostly happens with GuiApplication, because it derived from QApplication, because it already uses override. On the long term, all our virtual functions reimplementation should use override, although it is only of declarative value, like const. JMarc
