Today I tried LyX 2.3.2 with Python 3.7.2 and found that all image
conversions failed. I investigated and I found out that this commit
introduced the problem:
5b160e82
Line 38 fails since there is no .decode() for strings.
Also line 35 fails but strangely not line 29.
Attached is the diff to get it at least to work.
José, could you please have a look?
Besides this I don't understand why we limit the depth for image
conversions to 8 bit:
sopts = "-depth 8"
I cannot see a reason for this limitation. So if there is no longer one,
sopts should be kept empty in line 22.
thanks and regards
Uwe
diff --git
"a/C:\\Users\\USti\\AppData\\Local\\Temp\\TortoiseGit\\convertDefault-4162ed1.000.py"
"b/D:\\LyXGit\\Master\\lib\\scripts\\convertDefault.py"
index 8678965013..3a2cd645aa 100644
---
"a/C:\\Users\\USti\\AppData\\Local\\Temp\\TortoiseGit\\convertDefault-4162ed1.000.py"
+++ "b/D:\\LyXGit\\Master\\lib\\scripts\\convertDefault.py"
@@ -32,10 +32,10 @@ if fout.close() != None:
# caution: windows has a convert.exe for converting file systems
command = 'convert'
fout = os.popen('convert -version 2>&1')
- output = fout.readline()
+ #output = fout.readline()
fout.close()
if not PY2:
- output = output.decode()
+ output = output
version = re_version.match(output)
@@ -59,7 +59,7 @@ else:
# IM >= 5.5.8 separates options for source and target files
# See http://www.imagemagick.org/Usage/basics/#why
if im or gm:
- sopts = "-depth 8"
+ sopts = ""
topts = ""
elif sys.platform == 'darwin':
command = 'lyxconvert'
