On Wed, Feb 20, 2019 at 09:40:24AM +0100, Pavel Sanda wrote: > On Tue, Feb 19, 2019 at 11:35:53PM -0500, Scott Kostyshak wrote: > > I'm not sure when I would get to doing this, but for LyX's Git VC > > backend, would it be OK if I added support for multi-line commit > > messages? > > Sounds good. > > > I could format it similar to how Vim does it by default: > > > > - Subject line should be 50 characters. The user could enter more > > characters, but the additional characters will be marked in a > > different color, signaling that the recommended 50 has been exceeded. > > > > - There should be a blank line between the subject line and the body. > > > > - Wrap the body of the commit message to 72 characters. > > > > I'm not familiar with LyX's code. I'm guessing I should do as much as > > possible in the VC abstraction class, so that current and future > > backends could also optionally choose to have such features? > > That would be desirable, though you will need to check how that > will work with older VCSs, like RCS - I'm not even sure it accepts > multilines.
OK. > If you are going to encode newlines directly into commandline parameter > it's worth to ask how that fares in win/mac systems because they treat > them differently... Good point. I hadn't thought of that potential complication. Maybe it is better to use "git commit -F <file>". Scott
signature.asc
Description: PGP signature
