Dear Jean and lyx-devel@lists, So sorry, I have been really busy at work and completely forgot about this! I hereby grant permission to license my contributions to LyX under the GNU General Public License, version 2 or later
The above grant applies to any code I have, or will, email to lyx-devel@lists.
I have also attached another patch here that turns off the keyboard shortcuts
("!" and "space") that turn on/off autocrrect, as I find this feature
incrediably annoying and it is now unecesary thanks to the ability to
undo-autocorrects that Jean allready implemented. Note that you can still turn
autocorrect of/on using the checkbox in the options dialog.
I have not however removed references to this feature in docoumentation,
hopefully someone more familiary with the LyX code base will know where these
are.
And finally, I have another patch, (relying on the above) that places
autocorrect at the top of `InsetMathNest::interpretChar`, ensuring that any
autocorrections that trigger on special characters (such as '^' or '~') work.
In particular, you can now make an autocorrection from "<~" to "\preceq"!
On a side note, when I build LyX on windows (using MSVC 2017), I get an
annoying console window when I run LyX, it also seems to run slower than when I
build for linux.
— Isaac Oscar Gariano
________________________________
From: Jean-Marc Lasgouttes <[email protected]>
Sent: 25 May 2019 12:56 AM
To: Isaac Oscar Gariano; LyX Mechanics
Subject: Re: [PATCH] Make math autocorrrect work with more than 2 chars
Der Isaac,
For this to go forward, I at least need a statement "I hereby grant
permission to license my contributions to LyX under the GNU General
Public License, version 2 or later" that is sent not to me, but also to
[email protected].
Could you do that, so that this part of your work goes to 2.4.0dev?
Thanks,
JMarc
Le 17/04/2019 à 09:27, Jean-Marc Lasgouttes a écrit :
> Le 17/04/2019 à 01:25, Isaac Oscar Gariano a écrit :
>> Dear Jean-Marc,
>
> Dear Isaac,
>
> Please remember to keep the list in copy to your mails.
>
>>
>> I have looked over you're changes and the seem to work.
>>
>> A few things:
>>
>> * I hereby grant permission to license my contributions to LyX under
>> the GNU General Public License, version 2 or later
>
> I would need you to send this statement to the lyx-devel list for
> archival purpose.
>
>> * What do you mean by a "* a more consistent commit log for your
>> patch"?
>
> Sorry, it was a French/English false friend. I meant that git commit
> should be longer a describe a bit what the commit does. You can use 'git
> log' in the source tree to see how we use it.
>
>> * One thing that is annoying, is that autocorrect keeps turning off
>> when I press space (which I often do out of habit). Now that we have
>> the Ctrl-Z option, perhaps we can just keep the button in the
>> preferences window as the only way to turn autocorrect on and off;
>> in addition, could we add configurable shortcuts equivalent to using
>> the checkbox?
>
> I agree that this !/<space> thing is a bit annoying. I would not be
> against removing it completely. Is there someone who would object?
>
> Can you propose a patch?
>
>> * As for autocorrections to add, a few things come to mind, "..." to
>> "\ldots" (we allready have ".." though that does this), "==>" for
>> \Longrightarrow, "<=>" for \Leftrightarrow", ||- for models, ::=
>> for \Coloneqq, and other similar symbols. And of course prefecing
>> symbols with a '/', e.g. '/<=' for \nleq.
>
> Could you propose a patch to lib/autocorrect?
>
>> * I wanted to make <~ an alias for \preceq, however it seems that '~'
>> is translated to '\sim' /before/ the autocorrect code sees it; as
>> such I had to make it autocorrect \sim< instead.
>
> Is ~ a dead key on your keyboard?
>
> JMarc
0001-Removed-shortcuts-to-toggle-autocorrect.patch
Description: 0001-Removed-shortcuts-to-toggle-autocorrect.patch
0002-Make-autocorrect-have-priority.patch
Description: 0002-Make-autocorrect-have-priority.patch
