Am 08.09.2019 um 10:57 schrieb Stephan Witt <st.w...@gmx.net>: > > Am 25.09.2018 um 17:21 schrieb Stephan Witt <st.w...@gmx.net>: >> >> Am 25.09.2018 um 17:10 schrieb Jürgen Spitzmüller <sp...@lyx.org>: >>> >>> Am Freitag, den 21.09.2018, 15:55 +0200 schrieb pdv: >>>> I came across a deprecated call in the LinkBack code, and discovered >>>> that LinkBack acctually doesn't work (anymore). >>>> Apparently nobody uses this? >>> >>> Apparently. I only found this 8 year old bug related to LinkBack: >>> https://www.lyx.org/trac/ticket/6961 >>> >>> >>>> When the pasteboard contains linkback-data lyx saves the pdf-data + >>>> linkback-data in a file with the .linkback extension and adds the >>>> size >>>> of the pdf-data as a uint32. >>>> >>>> When reading/rewriting back the size it's converted with >>>> NSSwapBigLongToHost() and NSSwapHostLongToBig() calls. >>>> >>>> I suppose that the "Long" refers to 8 bytes. >>>> >>>> Replacing the calls by the similar "Int" calls solves the problem. >>>> >>>> LinkBack then works with LateXiT and with Omnigraffle. >>>> >>>> Enclosed is a patch for this and for replacing the deprecated call. >>> >>> Alas, I know nothing of this. Stephan? >> >> I’ll see if I can find the time. > > I’ve applied the patch and have no problem. I didn’t do the real test with > linkback-data. > I don’t have Omnigraffle an my system. > > The change from NSSwapBigLongToHost to NSSwapBigIntToHost is 100% correct. > I’ll commit to master. Thank you Patrick for fixing this bug.
I’ve commit it to master. Patrick, can we close the ticket in LyX’s bug tracker? Riki, I think we should back port the change to stable. Ok? Stephan
