On 9/13/19 11:09 AM, Jean-Marc Lasgouttes wrote: > Le 13 septembre 2019 16:15:52 GMT+02:00, Jean-Marc Lasgouttes > <lasgout...@lyx.org> a écrit : >> commit 714113655ad434f9a73d0101038568d59311af72 >> Author: Jean-Marc Lasgouttes <lasgout...@lyx.org> >> Date: Fri Sep 13 16:23:49 2019 +0200 >> >> Follow some of the performance advice from cppcheck >> >> Most of that is changing string to string const &. > There are 3 warnings that I did not fix in BiblioInfo.cpp about passing a > BiblioInfoList array by value. > > I figured I can ask first : is there a reason for copying the array or is it > an oversight?
Looking at git blame, it definitely looks like just an oversight. I can't see any reason for it not to be a const ref. I've fixed it. Riki