On Mon, 2 Apr 2001, Angus Leeming wrote:
> > 7) I find it a bit weird that I call a method "valid(bool)" whenever
> > e.g. a user types another character in a line edit widget. Can we
> > add another method mutated(bool) or changed(bool) possibly ?
> > This would make at least the KDE frontend code a lot clearer IMHO
There's more than simply "changed/unchanged". valid() should only be
called when a change has happened. So it represents "valid
changed/invalid changed". You are also free to call bc.input(SMInput)
directly.
> The name reflects the original function. The function has changed, so why not
> the name.
If the function has changed so that it no longer means "that was a valid
input from the user" then I hope you also made appropriate changes to the
state machines because they are all defined based on the definition that
SMI_VALID represents a valid user input.
>From the quick look I just had at ButtonPolices.[hC] and
ButtonControllerBase.[hC] it seems that bc.valid() still means that the
user just entered a valid input. I didn't think you had changed this.
Angus, I know you were going to reimplement the input checking functions
of the dialogs to return an SMInput but this doesn't seem to have been
done yet.
[long pause]
Okay I think I see what John is complaining about now: all those direct
calls to bc_.valid() in an effort to force the OK button to be available
all because the input checking doesn't return true when it should. That
was what the change in the dialog.input() checking was supposed to fix.
John, don't change the valid() function name or add another one. Wait
for Angus or I to change the operation of the dialogs input checking.
Then you won't need those direct calls to bc().valid() just to workaround
a mishandled input routine.
Allan. (ARRae)
