On 10/10/20 6:24 PM, Pavel Sanda wrote: > On Fri, Oct 09, 2020 at 06:12:01PM -0400, Richard Kimberly Heck wrote: >> On 10/9/20 5:34 PM, Pavel Sanda wrote: >>> On Thu, Oct 08, 2020 at 09:57:00PM -0400, Richard Kimberly Heck wrote: >>>>> Implementation-wise it could be just variant of page-break inset when you >>>>> look >>>>> at the semantics, painting-wise it would belong to the newline inset. Or >>>>> it >>>>> could be completely standalone inset. The semantic version seem most >>>>> appropriate >>>>> to me. Opinions? >>>> No objection. I'd add it to InsetPageBreak. >>> That would be like the attached. First iteration without format changes yet. >> Looks mostly fine. Two things. First, there's a lot of indentation >> weirdness. Second, I get the words "No page break" below the arrow >> symbols. Did you mean to return after the specialized drawing routine? > Indeed, return was removed while I was polishing the patch. > Whitespace issues hopefully fixed and format update included as well.
Looks fine to me. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
