On 10/16/20 4:26 PM, Yuriy Skalko wrote:
It is probalby worth retaining the 'const' for passing by value. It'd be
meaningless for return values.
Riki
It is not hard to add `const` again. But here is another important
question -- consistency. If you look on any function in LyX with int or
bool parameter, it will be without `const` and still is not modified
inside the function in 99% cases. I think it is not worth to add it
there and to leave here.
Also I cannot remember the usage of `const` for value parameters in any
common C++ library.
I wouldn't know about that. But the same reasons to declare variables
const would seem to apply here, no?
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
