On 11/8/20 12:12 PM, Scott Kostyshak wrote: > On Sun, Nov 08, 2020 at 11:32:59AM +0100, Pavel Sanda wrote: >> Scott/Kornel will presumably review/check the testing part. > I don't have much time to review or help, although I would be happy to take a > look in the future (possibly not for a while though). Thanks to Pavel and > Kornel for giving comments, and thanks to Sam for jumping down this rabbit > hole!
Agreed. This code needs some TLC. Can I make one suggestion about how to improve it? As it is now, it compares files character by character. This can lead, in my experience, to some weird and hard to read diffs. Would it be possible to adapt it so that it could also read word by word where those are, say, split by whitespace? I know that in some languages that would not make sense, so this could be a choice the user could make. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
