Sure thing, done. On Tue, Apr 13, 2021 at 6:57 PM Richard Kimberly Heck <rikih...@lyx.org> wrote:
> On 4/13/21 8:38 PM, Narahari Rao wrote: > > I've got it mostly working now. I couldn't figure out how to persist the > option (In Tools->Preferences->Colors), so it resets to Same As System > every startup. The patch is attached. > > Great, thanks! I should be able to take it from there. > > Can you send an email to the list saying that you license your > contributions to LyX under GPL v2 or any later version? Then we can give > you proper credit. > > Riki > > > > On Tue, Apr 13, 2021 at 12:51 PM Narahari Rao <narahari...@gmail.com> > wrote: > >> Looks like bool ColorCache::isDarkmode() is setting the document colors >> on startup, using QtPalette to get text/bg color and comparing them to >> guess whether the user is in a dark theme or not. However, changing what >> this function returns during runtime (via a variable) does not change the >> document colors, so it looks like it needs a refresh of some sort. >> >> On Tue, Apr 13, 2021 at 8:33 AM Jean-Marc Lasgouttes <lasgout...@lyx.org> >> wrote: >> >>> Le 13/04/2021 à 16:55, Richard Kimberly Heck a écrit : >>> >> Not in the GUI. You can use the -style option when starting LyX. >>> > >>> > Does it seem worth having such an option? Windows users especially >>> might >>> > struggle with the command line. I'd be happy to write the code, if so, >>> > if you can just point me at the dark-mode detection routine. >>> >>> Yes, I think a choice light/dark/system-default would be nice. >>> >>> JMarc >>> -- >>> lyx-devel mailing list >>> lyx-devel@lists.lyx.org >>> http://lists.lyx.org/mailman/listinfo/lyx-devel >>> >> >
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
