Am Mon, 7 Jun 2021 20:03:47 +0200
schrieb Yu Jin <yu_...@lyx.org>:

> Am Mo., 31. Mai 2021 um 16:42 Uhr schrieb Pavel Sanda <sa...@lyx.org>:
> 
> > On Sat, May 29, 2021 at 06:47:05PM +0200, Yu Jin wrote:
> > > > But I also think that the "universal" function calls (CreateNamedPipe()
> > > > and WaitNamedPipe()) should be made specific (CreateNamedPipeA() and
> > > > WaitNamedPipeA()), because the arguments are also specific (c_str()
> > always
> > > > returns const char*). I have attached the patch showing it, the patch
> > alone
> > > > fixes the compilation with unicode definition (can I commit it?). Once
> > Qt
> > > > 6.1.1 releases though, I will create a patch to disable unicode in
> > CMake
> > > > again.
> > > >
> > > Forgot the patch.
> >
> > It's inside _WIN32 section, thus safe for other archs. So I'd say go on
> > and commit. :)
> >
> 
> Thanks, Qt 6.1.1 released today, as mentioned I have prepared the patch for
> CMake, please review. I have tested successfully with both Qt6 and Qt5. On
> Qt5 it does nothing, because the property did not exist back then I guess.
> Note: With this version Qt6 sets UNICODE for basically everything now, so
> also libraries and console applications, so the patch deactivates it for
> all main targets.

Compiles fine on Linux with Qt5. Cannot test Qt6.

        Kornel

Attachment: pgpFQ6OS32Hf6.pgp
Description: Digitale Signatur von OpenPGP

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to