Hi Thibaut,

the Apple clang compiler spits warnings for InsetMathScript.cpp:


/Users/lyx/Development/lyx/src/mathed/InsetMathScript.cpp:619:11: warning: 
variable 'tag' is used uninitialized whenever 'if' condition is false 
[-Wsometimes-uninitialized]
        else if (d)
                 ^
/Users/lyx/Development/lyx/src/mathed/InsetMathScript.cpp:622:13: note: 
uninitialized use occurs here
        ms << MTag(tag);
                   ^~~
/Users/lyx/Development/lyx/src/mathed/InsetMathScript.cpp:619:7: note: remove 
the 'if' if its condition is always true
        else if (d)
             ^~~~~~
/Users/lyx/Development/lyx/src/mathed/InsetMathScript.cpp:614:18: note: 
initialize the variable 'tag' to silence this warning
        const char * tag;
                        ^
                         = nullptr

The attached patch makes it happy. It avoids the superfluous test for the bool 
d but I left it in comment to make the logic clear. Do you like it?

BR, Stephan

Attachment: patch.diff
Description: Binary data

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to